Skip to content

Conversation

@alandefreitas
Copy link
Member

The PR fixed problems related to MrDocs:

  • CMakeLists.txt supports being used as the root script. Mrdocs calls cmakelists.txt as the root build script instead of the boost superproject script. When the build script is in the CMake root source directory, we need to include the Boost targets so that the include paths are found. Otherwise, you'll get compilation errors because of missing headers. In root mode, you'll get:
    • a BOOST_SRC_DIR option that can be used to set the directory with other boost libraries (the default being ../..)
    • Some logic to check if this boost source dir is valid
    • And logic to include this boost dir as a subproject, only including the dynamicbitset dependencies and excluding dynamicbitset itself.
  • The mrdocs config is set to multipage because:
    • The single page is immense. No human can read that.
    • Even loading it was taking too long.
    • Also, the Antora extension only supports multipage for now (IIRC), so any tests with single pages aren't going to be used.
    • The recursive index page is looking pretty good for this library

Feel free to change anything you don't like and treat anything here as just a suggestion.

@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.28%. Comparing base (ead1fcb) to head (e78467a).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #95      +/-   ##
===========================================
- Coverage    94.91%   94.28%   -0.63%     
===========================================
  Files            5        4       -1     
  Lines          668      490     -178     
  Branches       211        0     -211     
===========================================
- Hits           634      462     -172     
+ Misses          33       28       -5     
+ Partials         1        0       -1     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead1fcb...e78467a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gennaroprota gennaroprota merged commit f91022c into boostorg:develop Sep 5, 2025
104 of 121 checks passed
@gennaroprota
Copy link
Collaborator

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants